Skip to content
This repository has been archived by the owner on Mar 13, 2021. It is now read-only.

Pick up Node Function and Yarn Buildpack new releases #288

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Pick up Node Function and Yarn Buildpack new releases #288

merged 1 commit into from
Apr 2, 2020

Conversation

fbiville
Copy link
Contributor

@fbiville fbiville commented Apr 1, 2020

No description provided.

@fbiville fbiville requested a review from scothis April 1, 2020 15:40
scothis
scothis reviewed Apr 2, 2020
View reviewed changes
builder.toml.tpl Outdated Show resolved Hide resolved
@fbiville fbiville requested a review from scothis April 2, 2020 08:59
@fbiville fbiville force-pushed the pick_new_releases branch from 16037f9 to 8315e96 Compare April 2, 2020 09:25
scothis
scothis reviewed Apr 2, 2020
View reviewed changes
Copy link
Member

@scothis scothis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect to see an update to the builder.toml.tpl.tpl file

@fbiville fbiville requested a review from scothis April 2, 2020 13:23
@fbiville
Copy link
Contributor Author

fbiville commented Apr 2, 2020

I'd expect to see an update to the builder.toml.tpl.tpl file

Yep, I missed the tpl_escape call when I initially introduced the Yarn buildpack.
Now fixed.

@fbiville fbiville force-pushed the pick_new_releases branch from 4f32f7e to 51f40fa Compare April 2, 2020 13:30
@fbiville fbiville merged commit cfa0b3d into projectriff:master Apr 2, 2020
@fbiville fbiville deleted the pick_new_releases branch April 2, 2020 13:38
@nebhale nebhale added semver:patch A change requiring a patch version bump type:dependency-upgrade A dependency upgrade labels Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scothis scothis scothis approved these changes

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump type:dependency-upgrade A dependency upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbiville @scothis @nebhale